Skip to content

Adjust FE components for MR approval rules - responsive view

Paulina Sedlak-Jakubowska requested to merge 432719-adjust-fe-components-unify-resposive-view into master

What does this MR do and why?

After working on Adjust MR approval rules: visual tweaks, I noticed some inconsistencies in a responsive version of approvals. Here are some improvements:

  • make sure all table headers have a visible name, when table changes to collapsed state on mobile
  • ensure the spacing is consistent (adjust classes, don't render empty elements)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Project Settings for MRs Single MR edit view
Screenshot_2024-01-18_at_14.54.48 Screenshot_2024-01-23_at_17.06.53
Screenshot_2024-01-18_at_14.54.58 Screenshot_2024-01-23_at_17.07.17

How to set up and validate locally

  1. Choose a project and go to Settings > Merge request
  2. Scroll down to Merge request approvals.
  3. To test changes in MR edit view select an existing MR and click Edit buttn
  4. Scroll down, between Reviewers and Milestone, expand Approval rules. To test the footer of the card, I temporarily removed this condition form the code.

Numbered steps to set up and validate the change are strongly suggested.

Related to #432719 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports