Skip to content

Use component_version_id instead component_id for

Zamir Martins requested to merge use_component_version_id_for_locations into master

What does this MR do and why?

Use component_version_id instead component_id for sbom related location. As suggested in !141129 (comment 1729439592), this only address the functionality issue without addressing the variable renaming.

EE: true Changelog: fixed

Related issue: #439048 (closed)

DB queries

Before (with component_id)

Query plan

SELECT
    sbom_occurrences.id,
    sbom_occurrences.created_at,
    sbom_occurrences.updated_at,
    sbom_occurrences.component_version_id,
    sbom_occurrences.project_id,
    sbom_occurrences.pipeline_id,
    sbom_occurrences.source_id,
    sbom_occurrences.commit_sha,
    sbom_occurrences.component_id,
    sbom_occurrences.uuid,
    sbom_occurrences.package_manager,
    sbom_occurrences.component_name,
    sbom_occurrences.input_file_path,
    sbom_occurrences.licenses,
    sbom_occurrences.highest_severity,
    sbom_occurrences.vulnerability_count,
    sbom_occurrences.source_package_id
FROM
    sbom_occurrences
WHERE
    sbom_occurrences.component_id = 1656 AND
    sbom_occurrences.project_id IN (
        SELECT
            projects.id
        FROM
            projects
        WHERE
            projects.namespace_id IN (
                SELECT
                    namespaces.traversal_ids[array_length(
                        namespaces.traversal_ids,
                        1
                    )] AS id
                FROM
                    namespaces
                WHERE
                    namespaces.type = 'Group' AND
                    traversal_ids @> '{58895632}'
            )
    );

After (with component_version_id)

Query plan

SELECT
    sbom_occurrences.id,
    sbom_occurrences.created_at,
    sbom_occurrences.updated_at,
    sbom_occurrences.component_version_id,
    sbom_occurrences.project_id,
    sbom_occurrences.pipeline_id,
    sbom_occurrences.source_id,
    sbom_occurrences.commit_sha,
    sbom_occurrences.component_id,
    sbom_occurrences.uuid,
    sbom_occurrences.package_manager,
    sbom_occurrences.component_name,
    sbom_occurrences.input_file_path,
    sbom_occurrences.licenses,
    sbom_occurrences.highest_severity,
    sbom_occurrences.vulnerability_count,
    sbom_occurrences.source_package_id
FROM
    sbom_occurrences
WHERE
    sbom_occurrences.component_version_id = 8365 AND
    sbom_occurrences.project_id IN (
        SELECT
            projects.id
        FROM
            projects
        WHERE
            projects.namespace_id IN (
                SELECT
                    namespaces.traversal_ids[array_length(
                        namespaces.traversal_ids,
                        1
                    )] AS id
                FROM
                    namespaces
                WHERE
                    namespaces.type = 'Group' AND
                    traversal_ids @> '{58895632}'
            )
    );

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-01-05_at_16.07.41 Screenshot_2024-01-05_at_16.07.06

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Zamir Martins

Merge request reports