Skip to content

Show pending banner to main namespace owners

Ammar Alakkad requested to merge 431187-show-banner-for-group-owners-only into master

What does this MR do and why?

In !141584 (merged) we showed a pending members banner in the group members page, however, we had the link of the current group and the banner will show for the current group's owner.

This MR will show pending banner to main namespace owners (so sub-group's owner won't see the banner since they might not have owner permission on the parent group).

And make the banner point to the main namespace pending_members path not the sub-group path (there is no pending_members path for sub-groups only for main groups).

Related to #431187 (closed) and Slack thread.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

parent group sub group
Screenshot_2024-01-18_at_09.11.58 Screenshot_2024-01-18_at_09.11.59

How to set up and validate locally

  1. Enable saas_user_caps feature flag
  2. Run GDK in SaaS mode
  3. As admin/owner, navigate to a group's members page (Group page > Manage > Members)
  4. Verify the alert is showing with a link
Edited by Ammar Alakkad

Merge request reports