PoC: Vertical split for users.incoming_email_token - step 5
DO NOT MERGE
What does this MR do and why?
This is PoC example MR on how to do a vertical split for a database table - extract column(s) and index(es) to a new table.
This is the final step 5 from the process, that does the following:
- Remove the ignore rule for the
users.incoming_email_token
column
See #430906 (closed) for more details.
Merge request reports
Activity
changed milestone to %16.10
assigned to @krasio
changed milestone to %17.0
2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @radbatnag
(UTC+8, 5 hours behind author)
@dblessing
(UTC-6, 19 hours behind author)
database @alexpooley
(UTC+8, 5 hours behind author)
@tigerwnz
(UTC+10.5, 2.5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded Category:Database label
requested review from @stomlinson
added 1934 commits
-
bf304995...250910b3 - 1933 commits from branch
ka/spikes/430906-vertical-split-incoming_email_token-step-4
- 5dd9c1f9 - Remove ingnore rule for incoming_email_token
-
bf304995...250910b3 - 1933 commits from branch
added 332 commits
-
5dd9c1f9...74a48dac - 331 commits from branch
ka/spikes/430906-vertical-split-incoming_email_token-step-4
- 6c3480f7 - Remove ingnore rule for incoming_email_token
-
5dd9c1f9...74a48dac - 331 commits from branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 6c3480f7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 65 | 0 | 1 | 0 | 66 | ✅ | | Create | 49 | 0 | 10 | 0 | 59 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 258 | 0 | 14 | 0 | 272 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label