Skip to content

Remove `oauth-login-...` ID from SSO sign ups

Eduardo Sanz García requested to merge eduardosanz/remove-id-from-sso-sign-up-buttons into master

What does this MR do and why?

The single sign-on buttons have a oauth-login-[provider] ID in two different contexts:

  • Sign in
  • Sign up

The ID is unnecessary for the sign up context, so we have decided to remove them to avoid confusion.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Go to /users/sign_up; SSO buttons shouldn't have the ID.
  2. Go to /-/trial_registrations/new (emulate SaaS); SSO buttons shouldn't have ID.
  3. Go to /users/sign_in; SSO buttons should retain the ID.

Merge request reports