Skip to content

Swap from timeouts to threading to manage CLI runtime in specs

Sarah Yasonik requested to merge sy-wait-for-cli-specs into master

What does this MR do and why?

Harden Internal Events CLI specs against flakiness (!140156 - merged) was meant to address some recurring flakiness in the internal events CLI specs. It helped, but the root problem still exists. This MR swaps from making assertions after a fixed timeout to waiting for the assertion to become true. The specs are more stable and run faster as a result.

Related issues:

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

bundle exec rspec spec/scripts/internal_events/cli_spec.rb

Merge request reports