Skip to content

Draft: Fix RemoveExpiredMembersWorker bug with removing subresources

Andrew Evans requested to merge 433963-fix-remove-expired-members-worker into 16-6-stable-ee

What does this MR do and why?

Fix Members::DestroyService bug with removing subresources: #433963 (closed)

Fixes a bug where the Members::DestroyService would be called recursively with no current_user and attempt to log an audit event without an author parameter. This was encountered by a customer when running the RemoveExpiredMembersWorker .

Also adds a spec exception for the blind rescue in RemoveExpiredMembersWorker ; the blind rescue made it difficult to reproduce the customer circumstances and encounter the error. It should not be necessary when running tests.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #433963 (closed)

Merge request reports