Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,939
    • Issues 34,939
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,282
    • Merge Requests 1,282
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !14182

Merged
Opened Jun 17, 2019 by Ash McKenzie@ashmckenzie🌴Maintainer4 of 11 tasks completed4/11 tasks

Snowplow - setUserId to User.id if available for gitlab.com

  • Overview 199
  • Commits 1
  • Pipelines 28
  • Changes 5

What does this MR do?

Include current user ID when tracking events with Snowplow, only if all of the following are true:

  • If Snowplow is configured and enabled in the Admin Settings
  • And finally, if the current_user:
    • Is available (is a user signed in)

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • [ ] Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes: https://gitlab.com/gitlab-org/telemetry/issues/57 Closes: https://gitlab.com/gitlab-org/telemetry/issues/97

Edited Nov 17, 2020 by David Sakamoto
Assignee
Assign to
Reviewer
Request review from
12.5
Milestone
12.5 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!14182
Source branch: 57-add-user_id-to-snowplow-event-tracking

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.