Skip to content

Remove sast_reports_in_inline_diff frontend

What does this MR do and why?

This MR removes the Frontend Implementation of the sast_reports_in_inline_diff feature flag.

  • It removes all conditions that where needed to switch between the old and the new version of the inline findings.
  • It removes the frontend Implementation of the old inline-findings implementation.

Screenshots or screen recordings

sast_reports_in_inline_diff true

no visual changes
Screenshot_2024-01-16_at_13.46.25

sast_reports_in_inline_diff false

functionality was removed, no more findings shown

before after
Screenshot_2024-01-16_at_13.49.10 Screenshot_2024-01-16_at_13.46.25

How to set up and validate locally

  1. Enable sast_reports_in_inline_diff
  2. Make sure your running an ultimate license or your GDK (how to)
  3. Clone this repo: https://gitlab.com/jannik_lehmann/cq-and-sast-test
  4. Recreate this MR for SAST & CodeQuality findings: jannik_lehmann/cq-and-sast-test!6 (diffs)
  5. Let the pipeline finish and the go checkout the diff page.
Edited by Jannik Lehmann

Merge request reports