Skip to content

Stop preloading policies for namespaces on self-managed instances

Mohamed Hamda requested to merge refactor-user-assignments-resolver into master

What does this MR do and why?

The GroupPolicy preloader is specifically required for SaaS instances, as add-on purchases consistently feature a nil namespace on self-managed (SM). Consequently, there's no necessity to preload namespaces on SM. A previous solution involved compacting and removing nils to allow the preloader to pass. However, this fix focuses on refining the process by invoking the preloader exclusively for SaaS instances, where it is intended to be utilized.

In this merge request (MR), the following actions are taken:

  • Ceasing the preloading of policies for Namespaces on SM.
  • Introducing the loading of GroupPolicy exclusively for SaaS instances.
  • Refactor specs

Relates to: https://gitlab.com/gitlab-org/gitlab/-/issues/435122

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mohamed Hamda

Merge request reports