Onboarding Component: Use lastStepIndex in percentageCompleted
What does this MR do?
This is one of many small MRs for the new user onboarding feature, see https://gitlab.com/gitlab-org/gitlab-ce/issues/60093.
Based on the discussion in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/11852#note_178527882, this MR adds changes to the percentageCompleted getter in order to use the state's lastStepIndex for computing the percentageCompleted value (which is displayed in the progress bar of the onboarding component).
Moreover, it adjusts the percentageCompleted values for each step (see also https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/11852#note_181647333)
Example:
On the very first first step of the first tour it should „0/13 steps completed“.
Screenshots:
| before | after |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team