Skip to content

Remove/convert to utility classes non-page specific styles for profile

Elwyn Benson requested to merge 239863-page-specific-bundles-profile into master

What does this MR do and why?

Part of the page-specific-scss migration effort.

Removes classes from profile.scss. Some were unused, and some could be easily converted to utility classes.

See screenshots for details.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Project -> Settings -> Repository -> Mirroring repositories -> Add New

.account-well styles lived inside profile.scss, this was the only usage. Removed the class and (approximately) replicated styles with utility classes

Before After
image image
image image

Admin -> Applications

.oauth-applications styles lived inside profile.scss. This was 1 of 2 usages of the class. It was not actually doing anything in this context, removed the class (replaced with data-testid to keep specs passing)

Before After
image image (no visual difference)

Group -> Settings -> Applications

Again .oauth-applications used here. Removed (replaced with data-testid to keep specs passing) and added utility classes to replicate existing functionality (...almost exactly...).

Before After
image image (last table column is a few px width different)

How to set up and validate locally

See screenshots above for the various places impacted by this MR.

I'm not super familiar with some of the areas impacted so appreciate any extra sanity testing for other places I've unintentionally changed

Related to #239863 (closed)

Edited by Elwyn Benson

Merge request reports

Loading