Add discouragement of adding new lines in rubocop todo files
What does this MR do and why?
Add discouragement of adding new lines in rubocop todo files
- todo files should not be added to. They are meant for eventually resolving, not as a forever list of exceptions.
- no docs updated as I couldn't think of the need for it after reading the current docs at https://docs.gitlab.com/ee/development/rubocop_development_guide.html#disabling-rules-inline
- moves all rubocop concerned suggestors code out of Dangerfile into a module for ease of testing.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Add a line to existing todo file locally.
- Add and commit to git.
- Run danger local
bundle exec rake danger_local
Related to #438072 (closed)
Edited by Doug Stull