Skip to content
Snippets Groups Projects

File collapse: fix spelling and phrasing in UI text

Merged Amy Qualls requested to merge 391777-aqualls-fix-string into master
All threads resolved!

What does this MR do?

!139210 (merged) introduced a spelling error into UI text. Let's fix that, and tighten up the language while we're here.

  • Current: Generated files are collapsed by default. This behavior can be overriden via .gitattributes file if required.
  • Initial proposal here: Generated files are collapsed by default. To change this behavior, edit the .gitattributes file.

Spotted from this screencap:

Screenshot_2024-01-23_at_10.34.36

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Phil Hughes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • removed review request for @msedlakjakubowski

  • 🤖 GitLab Bot 🤖 changed milestone to %16.9

    changed milestone to %16.9

  • mentioned in issue #438727 (closed)

  • Phil Hughes added 1 commit

    added 1 commit

    • bf62c239 - Updated generated file text to include code tag

    Compare with previous version

  • Phil Hughes changed the description

    changed the description

  • Phil Hughes requested review from @deepika.guliani

    requested review from @deepika.guliani

  • Contributor

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend @thutterer profile link current availability (UTC+1, 9 hours ahead of author) @eduardosanz profile link current availability (UTC+1, 9 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the 🔁 danger-review job that generated this comment.

    Generated by 🚫 Danger

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 4255c415 and a323e367

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.13 MB 4.13 MB - 0.0 %
    mainChunk 3.13 MB 3.13 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

  • Deepika Guliani approved this merge request

    approved this merge request

  • The changes look good to me 🙂 Approving 🚀

    Just one open thread and we are good to go 💃

    Edited by Deepika Guliani
  • Phil Hughes added 1 commit

    added 1 commit

    • c675c290 - Added learn more link to generated diff alert text

    Compare with previous version

  • Phil Hughes revoked approvals from @deepika.guliani by pushing to the branch

    revoked approvals from @deepika.guliani by pushing to the branch

  • Deepika Guliani approved this merge request

    approved this merge request

  • Deepika Guliani resolved all threads

    resolved all threads

  • @iamphill Hey 👋 Can you please have a look at the failing tests ? They look related

  • Phil Hughes added 1 commit

    added 1 commit

    • a323e367 - Added learn more link to generated diff alert text

    Compare with previous version

  • Phil Hughes revoked approvals from @deepika.guliani by pushing to the branch

    revoked approvals from @deepika.guliani by pushing to the branch

  • Phil Hughes requested review from @deepika.guliani

    requested review from @deepika.guliani

  • Phil Hughes unapproved this merge request

    unapproved this merge request

  • Thank you for working on fixing the tests @iamphill 🙇 Let us merge this 🚀

  • Deepika Guliani approved this merge request

    approved this merge request

  • Deepika Guliani enabled an automatic merge when all merge checks for a323e367 pass

    enabled an automatic merge when all merge checks for a323e367 pass

  • Deepika Guliani mentioned in commit 59c700fa

    mentioned in commit 59c700fa

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading