Skip to content

Fix edge case that makes GitHubImport UserFinder to fail

Rodrigo Tomonari requested to merge rodrigo/fix-user-finder-lock into master

What does this MR do and why?

Fix an edge case that could cause the error:

Sentry Error link - internal only

undefined method `headers' for nil:NilClass

  etag = client.octokit.last_response.headers[:etag]

On !140051 (merged), UserFinder was updated to only allow one request at a time among all GitHub Import jobs. However, a bug was introduced, which caused the error above.

This change fixes the bug

Related to: #435340 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Rodrigo Tomonari

Merge request reports