Skip to content

Allow setting inheritance type on protected env

Andrew Fontaine requested to merge afontaine/422392/approval-rules into master

What does this MR do and why?

Users have expressed interest in viewing and setting the group inheritance type on group approval rules for protected environments. We add a toggle at rule creation and at rule edit that allows users to manipulate that setting.

Changelog: added

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen_Recording_2024-01-09_at_2.34.30_PM

Screen_Recording_2024-01-09_at_2.35.12_PM

Screen_Recording_2024-01-09_at_2.35.41_PM

How to set up and validate locally

  1. Protect an environment, adding an approval rule. Verify toggling inheritance persists
  2. Add an approval rule, verify toggling inheritance persists
  3. Edit the rule, verify toggling inheritance persists

For #422392 (closed)

Edited by Andrew Fontaine

Merge request reports