Skip to content

Fix max_running_jobs for unlocking pipelines

lbausch requested to merge gitlab-community/gitlab:fix-unlock-pipelines-max-running-jobs into master

What does this MR do and why?

!140318 (merged) introduced the feature flag ci_unlock_pipelines_extra_low which, when enabled, should result in max_running_jobs returning MAX_RUNNING_EXTRA_LOW (10).

However, !134477 (merged) enabled the feature flag ci_unlock_pipelines by default, so the elsif condition by default always returns MAX_RUNNING_LOW - even with ci_unlock_pipelines_extra_low being enabled. Hence, one would need to disable ci_unlock_pipelines and enable ci_unlock_pipelines_extra_low to use MAX_RUNNING_EXTRA_LOW.

This MR moves the eslif condition for ci_unlock_pipelines_extra_low up so it is checked prior to that.

This came up when being affected by #435051

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by lbausch

Merge request reports