Skip to content

Hide visualization designer button if product analytics isn't onboarded

Elwyn Benson requested to merge 433988-analytics-visualization-designer-is-accessible-before-it-is-functional into master

What does this MR do and why?

Ensure the visualization designer button does not show on the analytics dashboard list before Product Analytics has been onboarded.

This is to prevent errors when trying to save visualizations before PA is onboarded.

The logic for showing both buttons is now separated - as Visualization Designer is a product analytics specific feature, but creating custom dashboards is not necessarily product analytics specific.

Note: two similar issues which are not addressed in this MR: #424631 (closed), #437709

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Project dashboard:

State Before After
PA: false, Custom dashboard project: false image image (unchanged)
PA: false, Custom dashboard project: true image image
PA: true, Custom dashboard project: false image image (unchanged)
PA: true, Custom dashboard project: true image image (unchanged)

Group dashboard: (no changes, buttons always hidden)

How to set up and validate locally

  1. Follow these instructions to setup Product Analytics in GDK.
  2. Create a new project
  3. Visit analytics dashboards at Project > Analytics > Analytics dashboards
  4. Verify New Dashboard and Viz Designer buttons are hidden
  5. Configure a custom dashboard project from the alert on the dashboards page
  6. Verify New Dashboard button is now available, but not Viz Designer
  7. Onboard Product Analytics by setting up the feature at Project > Analytics > Analytics dashboards.
  8. Verify both New Dashboard button and Viz Designer buttons are now available

Related to #433988 (closed)

Edited by Elwyn Benson

Merge request reports