Skip to content

Refactor GroupsFinder and (hopefully) fix performance issue

Robert May requested to merge refactor-groups-finder into master

What does this MR do and why?

Refactor GroupsFinder and (hopefully) fix performance issue.

In theory this should alleviate the problems documented in #425166 (closed), but also includes a refactor of the GroupsFinder because it was far harder to figure out what it was doing than should have been necessary.

This largely just makes the finder more linear in how it's laid out but doesn't change any functionality. I removed two unused methods, removed methods that wrapped only a variable, and reorganised the file to flow more logically.

The probable performance improvement comes from the change to use the filter_group_ids param.

Changelog: performance

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Robert May

Merge request reports