Upgrade redis gem to v5
What does this MR do and why?
This MR upgrades redis
gem from v4.8.0
to v5.0.8
. This MR is a tidied-up version of !134862 (closed) where the commits are re-organized for clarity.
See issue gitlab-com/gl-infra/scalability#2727 (closed)
Main changes are
- redis-cluster-store patch in
lib/gitlab/patch/redis_store_factory.rb
andlib/gitlab/redis/cluster_store.rb
- removal of cross-slot pipeline codes in
lib/gitlab/redis/cross_slot.rb
since redis gem v5 handles pipelining to multiple shards - fixing typing for inputs into the new redis gem client. included
lib/gitlab/redis/command_builder.rb
- actioncable initialisation to be compatible with redis-client in
config/initializers/action_cable.rb
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Review summary
-
backend reviewer approval from @dfrazao-gitlab
-
database reviewer approval from @dgruzd
-
groupauthentication approval from @dblessing
(already approved but it got revoked by new pushes) -
Redis subject matter expert approval from @marcogreg
-
clickhouse - to be done by @ahegyi
-
devopsverify - to be done by @drew
-
database maintainer - @ahegyi
-
backend maintainer - @drew
-
Quality - @at.ramya
Edited by Sylvester Chin