Skip to content

Replace signin-container for a more specific selector

Eduardo Sanz Garcíarequested to merge
eduardosanz/signin-container into master

What does this MR do and why?

A div element with the signin-container id was use for a JavaScript functionality to preserve the URL fragments and the remember_me query.

In this MR we replace the #signin-container by a more specific .js-non-oauth-login selector.

We also move the .js-oauth-login selector to the parent element so both, js-oauth-login and js-non-oauth-login, works similarly.

No CSS styling is associated to signin-container.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No difference.

How to set up and validate locally

No differences should be found in the pages where this div container was used:

  • /users/sign_in
  • /admin/session/new
Edited by Eduardo Sanz García

Merge request reports