Skip to content

Sec Finding details: Fix double-hash for file loc

What does this MR do and why?

Finding details: Fix double-hash for file location URL

In some cases, the blob-path, which is used to construct the link to the vulnerable file, contains the hash to the LOC. In others not.

This change adds a check to prevent adding the hash if it is already present.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-01-04_at_1.17.32_pm Screenshot_2024-01-04_at_1.17.45_pm

How to set up and validate locally

  1. Go to a pipeline with findings
  2. Click a finding result (SAST) to load the modal
  3. Check the link that goes to the file location

Related to #437121 (closed)

Edited by David Pisek

Merge request reports