Skip to content

Add upsert to database review guidelines

Doug Stull requested to merge 419366-add-upsert into master

What does this MR do and why?

Add upsert to database review guidelines

  • similar to update, destroy, etc, this method should require database review
  • update documentation to include upsert
  • introduce danger roulette rule to properly callout the database review.
    • note: we did not include update/delete/destroy in this detection as I felt it would lead to too many false positives(as they exist on enumerable as well) that would be hard to notice and we'd end up with more reviews errantly requested for database.
  • fine tune wording on existing bulk update commenter and shift to use inheritance pattern.
    • note: I didn't see this working properly and alerting before I changed it...odd.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #419366 (closed)

Edited by Doug Stull

Merge request reports