Skip to content

Draft: [DO NOT MERGE] Check if CI pipeline can use dev gems

Eric Ju requested to merge ej-5671-wait-for-git-log-to-finish-test-gem into master

What does this MR do and why?

Add CommitNotFound error

The FindCommits RPC in gitaly would throw a grpc error with code NotFound if it can't find any commits. In order to let rail consume the NotFound error, we will need to add some logic:

  • wrap NotFound error properly to differentiate Repo not found and Commits in that repo not found
  • git/repository.rb 's log method would return empty array if a Commit not found error happens.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports