Skip to content

Remove unused methods from Ci::CreatePipelineService

Hordur Freyr Yngvason requested to merge remove-unused-private-methods-from-ci-create-pipeline-service into master

What does this MR do and why?

The private methods sha and commit seem to not have been used since a refactoring in 2017, 9f844dd0. They cannot work, because the service does not have an origin_sha method. Therefore, they must be unused.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

It's easy to verify this by running the following snippet in GDK in a rails console:

service = Ci::CreatePipelineService.new(Project.last)
service.send(:sha)
Edited by Hordur Freyr Yngvason

Merge request reports