Protected packages: Return ServiceResponse for CreateNpmPackageService
What does this MR do and why?
Protected packages: Return ServiceResponse for CreateNpmPackageService
MR includes:
-
Returning a successful ServiceResponse as suggested by the best-practice documentation, see https://docs.gitlab.com/ee/development/reusing_abstractions.html#serviceresponse
-
This MR depends on Protected packages: Align return object of npm ... (!140010 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
- Changelog entry added, if necessary
-
Documentation created/updatedvia this MR -
Documentation reviewed by technical writerorfollow-up review issuecreated - Tests added for this feature/bug
-
Tested inall supported browsers - Conforms to the code review guidelines
-
Conforms to themerge request performance guidelines - Conforms to the style guides
-
Conforms to thejavascript style guides -
Conforms to thedatabase guides -
Wait for!140010
Screenshots or screen recordings
Only backend changes. No frontend changes.
How to set up and validate locally
- Execute the relevant tests
bundle exec rspec ./spec/requests/api/npm_project_packages_spec.rb spec/services/packages/npm/create_package_service_spec.rbRelated to #323970 (closed)
Edited by Gerardo Navarro