Skip to content

Fix quarantined N+1 spec

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/391442/fix-quarantined-n+1-spec into master

What does this MR do and why?

This MR fixes the quarantined spec in #391442 (closed). It:

  • replaces the current N+1 queries that request discrete runners with a more real-world scenario of requesting a list of runners.
  • changes the spec to take cached queries into account.
  • performs both GraphQL queries with the same user, since all other GraphQL N+1 specs are doing that (and it also matches the real-world usage).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Comment out the preloads. The tests should fail.

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports