Asciidoc max include application setting
What does this MR do and why?
This MR should work towards #216108 (closed)
-
adds a new application setting asciidoc_max_includes
which replaces the old hardcodedMAX_INCLUDES
, default value unchanged32
- naming is up for discussions
-
adds a new general preferences sectionAsciiDoc
which contains a number input for this settingthis is debatable and I'm looking forward to input on this
-
allows change of application setting via Rails Console
ApplicationSetting.update(asciidoc_max_includes: 5)
-
unsure about a sensible max value in the model validation - !140531 (diffs)
- Result: new max value will be set to
64
; !140531 (comment 1740507225)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
UI changes have been removed per this suggestion.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Go to the Settings > General > AsciiDoc
- Enter a max include setting that fits your test case
- Add a sample
.adoc
to your test project and check that the only the numer of configured includes are resolved
Edited by Daniel Haß