Skip to content

Upgrade redis-actionpack gem

Heinrich Lee Yu requested to merge 396273-upgrade-redis-actionpack into master

What does this MR do and why?

This upgrade adds Rack 3 compatibility.

Upgrade details

New Dependency: rack-session (1.0.2)
⚠ Latest version is not in use.

We can't use the latest version of rack-session because we're still on Rack 2. See https://github.com/rack/rack-session#compatibility.

This is a new gem we're adding but it's just code extracted from Rack.

Modified Dependency: redis-actionpack (5.4.0) Version diffs

Only gemspec and tests were changed here

Modified Dependency: redis-rack (3.0.0) Version diffs

https://github.com/redis-store/redis-rack/pull/73 is the only change here to add Rack 3 support. req.multithread? check is removed because this is removed in Rack 3.

We're running Puma which is multi-threaded, so there's no change in behavior here.

Modified Dependency: redis-store (1.10.0) Version diffs

Changes are here: https://github.com/redis-store/redis-store/releases/tag/v1.10.0. It's for redis-rb v5 compatibility (we're still on v4).

This isn't part of the Rack upgrade but was updated because it's a dependency of the above gems. I think this is worth just including here anyway since the changes are very small.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396273

Edited by Heinrich Lee Yu

Merge request reports