Skip to content

Use the same Rack version as the monolith

Lin Jen-Shin requested to merge limit-rack-version into master

What does this MR do and why?

Use the same Rack version as the monolith

If we don't limit the Rack version in gitlab-safe_request_store, it'll be resolved to Rack 3 (latest). However, in the monolith where we're actually using the gem, we're forced to use Rack 2 because of compatibility issue: #396273

This means we're not really testing with the Rack version we're really using in the monolith.

This should make this consistent and always test against Rack 2.

See also https://gitlab.com/gitlab-com/gl-security/security-assurance/governance-and-field-security/field-security-team/customer-assurance-activities/caa-servicedesk/-/issues/3185#note_1704249947

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Lin Jen-Shin

Merge request reports