Skip to content

Remove external link icons in pipeline security tab alerts

What does this MR do and why?

Update the alerts/warnings within the pipeline security report to not show the external-link icons.

This is to follow the Pajamas guidelines:

When linking to the GitLab documentation, don't add the external link icon. Even though documentation links on GitLab.com take the user to docs.gitlab.com, the same links on self-managed open in the instance's /help.

https://design.gitlab.com/usability/contextual-help#external-links

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2023-12-20_at_6.41.23_pm Screenshot_2023-12-21_at_2.17.31_pm

How to set up and validate locally

Apply the following diff:

diff --git a/ee/app/assets/javascripts/security_dashboard/components/pipeline/pipeline_security_dashboard.vue b/ee/app/assets/javascripts/security_dashboard/components/pipeline/pipeline_security_dashboard.vue
index 717c402a7f8a..80a438d8d42c 100644
--- a/ee/app/assets/javascripts/security_dashboard/components/pipeline/pipeline_security_dashboard.vue
+++ b/ee/app/assets/javascripts/security_dashboard/components/pipeline/pipeline_security_dashboard.vue
@@ -161,9 +161,9 @@ export default {
       />
     </p>
 
-    <div v-if="hasScans" class="gl-mb-5">
+    <div v-if="true" class="gl-mb-5">
       <scan-alerts
-        v-if="showScanErrors"
+        v-if="true"
         :type="$options.errorsAlertType"
         :scans="scansWithErrors"
         :title="$options.i18n.parsingErrorAlertTitle"
@@ -171,7 +171,7 @@ export default {
         class="gl-mb-5"
       />
       <scan-alerts
-        v-if="showScanWarnings"
+        v-if="true"
         :type="$options.warningsAlertType"
         :scans="scansWithWarnings"
         :title="$options.i18n.parsingWarningAlertTitle"
@@ -179,7 +179,7 @@ export default {
         class="gl-mb-5"
       />
 
-      <report-status-alert v-if="hasPurgedScans" class="gl-mb-5" />
+      <report-status-alert v-if="true" class="gl-mb-5" />
       <security-reports-summary :summary="reportSummary" :jobs="jobs" />
     </div>
 

Then visit a pipeline's security dashboard and verify that the external-link icon is now shown in any of the three alert/warning banners.

Related to #364034 (closed)

Edited by David Pisek

Merge request reports