Skip to content

Add tabindex for error badge in "Settings > Mirroring repositories"

Michael Le requested to merge 385066-focus-keyboard-for-error-badge into master

What does this MR do and why?

Adds a tabindex to the badge component so that it can be focused on keyboard navigation to display the error message.

Note: Considered changing the badge to a label component but not sure how to ensure the same color for "danger" when using a label.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
CleanShot_2023-12-19_at_23.07.43 badge-focus-after

How to set up and validate locally

  1. Go to Settings > Repository
  2. Expand "Mirroring repositories"
  3. Click on "Add new"
  4. Add a random/fake repository info to mirror so that an error occurs.
  5. Use keyboard to navigate buttons with tab key

Related to #385066 (closed)

Edited by Michael Le

Merge request reports