Skip to content

Fix product analytics settings available when disabled

What does this MR do and why?

This MR fixes some Product analytics settings remaining available even when disabled on an instance for Product analytics project-level settings remain... (#413981 - closed).

The following changes are made:

  • Hide Use product analytics in Groups > Settings when disabled on an instance.
  • Hide Data sources in Projects > Settings > Analytics when disabled on an instance.
  • Updates and adds applicable specs.

Note that Product analytics is an experimental feature that is hidden behind a default off feature flag.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Note: All screenshots taken with Admin > Settings > Enable product analytics set to false.

Groups > Settings > General Settings

Hides the Use product analytics setting.

Before After
image image

Projects > Settings > Analytics settings

Hides the Product analytics settings and Data sources section.

Before After
image image

Projects > Analyze > Analytics dashboards

No visual change.

Before After
image image

Instance setting enabled. No visual change.

Before After
image image

How to set up and validate locally

  1. Follow the instructions to set up Product Analytics on your devkit.
  2. Navigate to Admin Area > General > Product analytics and disable the Enable product analytics checkbox.
  3. View Groups > Settings > General Settings in a test group and validate that Use product analytics is hidden.
  4. View Projects > Settings > Analytics settings in a project in your test group and validate that Data sources is hidden.
  5. Repeat step 2, 3, 4 but enable Enable product analytics and verify that the settings are now displayed.

Related to #413981 (closed)

Edited by Jiaan Louw

Merge request reports