Skip to content

Revert "Merge branch 'issue_394984_check_if_SAN_fits_CN' into 'master'"

Daniel requested to merge xFuture603/gitlab:revert-90a7333a into master

What does this MR do and why?

This MR reverts the changes requested in #394984 (closed) due to the comment from @stanhu:

#394984 (comment 1699490855)

"I belatedly realized the error rate for this issue dropped to 0 in November, and the domain in question was working with LetsEncrypt.

But then I just found https://community.letsencrypt.org/t/simplifying-issuance-for-very-long-domain-names/207924:

Previously, requests where all DNS Names were longer than 64 characters resulted in a urn:ietf:params:acme:error:rejectedIdentifier error with the message “NewOrder request did not include a SAN short enough to fit in CN”. With this change, such requests will be processed successfully, albeit now without a CN.

I think this mean we can revert that merge request now. Would you mind submitting the revert?"

Revert "Merge branch 'issue_394984_check_if_SAN_fits_CN' into 'master'"

This reverts merge request !139584 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

Merge request reports