Skip to content

Draft: Tests: use headless=new chrome arg

Jay McCure requested to merge jmc-headless-fix into master

What does this MR do and why?

Prevents secondary error in tests occurring when using headless chrome:

     5.2) Failure/Error: console = page.driver.browser.logs.get(:browser)&.reject { |log| log.message =~ JS_CONSOLE_FILTER }

          NoMethodError:
            undefined method `logs' for #<Selenium::WebDriver::Chrome::Driver:0x29fcb3b496572ed0 browser=:"chrome-headless-shell">

                  console = page.driver.browser.logs.get(:browser)&.reject { |log| log.message =~ JS_CONSOLE_FILTER }
                                               ^^^^^
          # ./spec/support/capybara.rb:204:in `block (2 levels) in <main>'
          # ./spec/spec_helper.rb:420:in `block (3 levels) in <top (required)>'
          # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
          # ./spec/spec_helper.rb:411:in `block (2 levels) in <top (required)>'
          # ./spec/spec_helper.rb:407:in `block (3 levels) in <top (required)>'
          # ./lib/gitlab/application_context.rb:68:in `with_raw_context'
          # ./spec/spec_helper.rb:407:in `block (2 levels) in <top (required)>'
          # ./spec/spec_helper.rb:260:in `block (2 levels) in <top (required)>'
          # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
          # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
          # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
          # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports