Skip to content

Use clipboard button in dns partial and remove new deploy token partial

Missy Davies requested to merge gitlab-community/gitlab:md-button-helper into master

What does this MR do and why?

Resolves #417796 (closed)

This MR:

  1. converts all remaining deprecated_clipboard_button > clipboard_button for app/views/projects/pages_domains/_dns.html.haml
  2. and removes unused app/views/shared/deploy_tokens/_new_deploy_token.html.haml > see comment

Note:

  1. app/views/projects/notes/_more_actions_dropdown.html.haml is being converted in !140013 (merged), there's already an issue open for the file here #417839 (closed)
  2. app/views/ci/runner/_how_to_setup_runner.html.haml > see comment, this is being removed so we don't need to update the button

Screenshots

app/views/projects/pages_domains/_dns.html.haml

domain_dns button

Before After
Screenshot_2023-12-19_alle_3.47.54_PM Screenshot_2023-12-20_alle_9.04.29_PM

domain_verification button

Before After
Screenshot_2023-12-19_alle_3.48.08_PM Screenshot_2023-12-20_alle_9.04.23_PM

How to set up and validate locally

app/views/projects/pages_domains/_dns.html.haml

Setting up DNS locally is quite intensive so I simply copied the partial into a view I could access easily and verified there.

With pages setup locally, this could be tested directly in the feature at: http://gdk.test:3000/flightjs/Flight/pages

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Missy Davies

Merge request reports