Fixes bug in modal scroll
requested to merge gitlab-community/gitlab:420132-prevent-scrolling-of-elements-underneath-search-modal into master
What does this MR do and why?
Removes overflow-y scroll from HTML element, could not find any reason for this code and after testing in different browsers removing doesn't seem to have any side effects.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
| Screen Recording 2023-12-15 at 10.01.38.mov | Screen Recording 2023-12-15 at 09.55.51.mov |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Open the search modal
- Try to scroll it past its scrollable bounds (just keep scrolling down, for instance)
- Notice that the page underneath scrolls
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #420132 (closed)
Edited by James Rushford