Skip to content

Refactor LfsStorageController#upload_finalize into service

Missy Davies requested to merge gitlab-community/gitlab:md-lfs-upload-service into master

What does this MR do and why?

Resolves #233487 (closed)

This MR simplifies the Repositories::LfsStorageController#upload_finalize by abstracting the logic into a service for better readability.

How to set up and validate locally

  1. Run your gdk server locally
  2. Create a new project in gdk, make sure you add a README or any file so that the git repository is initialized
  3. Follow the steps to use git lfs normally:
    • git clone git@gitlab.example.com:group/my-sample-project.git
    • cd my-sample-project in terminal
    • git lfs install
    • git lfs track "*.iso"
    • add any large files to your directory
    • git add . this should add the large files as well as the .gitattributes
    • git commit -am "Added .gitattributes to capture LFS tracking"
    • git push origin main

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Missy Davies

Merge request reports