Skip to content

Improved CI YAML schema tests

Marco Zille requested to merge gitlab-community/gitlab:434840-zillemarco-improve-yaml-schema-tests into master

What does this MR do and why?

Related to #434840

While working on !137815 (merged) I noticed that using a global keyword on CI YAML schema test files multiple times is not supported.

This is now fixed with this MR, which could also solve other potential flaky test cases for the negative CI YAML schema tests 🙂

Screenshots or screen recordings

N.A.

How to set up and validate locally

  1. Run the CI YAML schema specs with yarn run jest spec/frontend/editor/schema/ci/ci_schema_spec.js
  2. Make sure they all pass 😅

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports