Skip to content

Fix reviewers and assignees working at the same time

Gary Holtz requested to merge 329978-assign-reviewers-and-unassign-from-reviewers-your-self-doesn-t-work-at-the-same-time into master

What does this MR do and why?

A certain combination of using "me" in and a quick action and actually referencing your username would sometimes lead to the incorrect result. Example (from #329978)

Some description

/assign me 
/assign_reviewer @user1 @user2
/unassign_reviewer me

This change should correctly parse them.

How to set up and validate locally

  1. Clone the repository and checkout the fix-reviewers-and-assignees-working-at-the-same-time branch.
  2. Run bundle install.
  3. Run the tests with rspec.
  4. Locally, try the following in an MR:
/assign me 
/assign_reviewer @available_local_user @your_username
/unassign_reviewer me
  1. Confirm you are assigned to the merge request, but not assigned as a reviewer.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #329978

This description was generated for revision 87e59346 using AI

Edited by Gary Holtz

Merge request reports