Skip to content

Routing is missing for group wiki search

Ravi Kumarrequested to merge
430812-routing-is-missing-for-group-wiki-search into master

What does this MR do and why?

It was sending only count_only options that's why ids were empty here: https://gitlab.com/gitlab-org/gitlab/-/blob/8d8d0e216f761b715f37ce8085869f687afcae8b/ee/lib/elastic/latest/wiki_class_proxy.rb#L37 and thus the routing was empty

Screenshots or screen recordings

Project search

Before After
before_project after_project

Group search

Before After
before_group after_group

How to set up and validate locally

  1. Ensure elasticsearch is enabled
  2. Perform a Group Wiki search. Verify that in the es query in the performance bar, you see the routing param
  3. Perform a Project Wiki search. Verify that in the es query in the performance bar, you see the routing param

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #430812 (closed)

Edited by Ravi Kumar

Merge request reports