Skip to content

Use new GraphQL client to paginate deploy keys

Andrew Fontainerequested to merge
afontaine/407604/frontend into master

What does this MR do and why?

This adds pagination to the deploy keys app, and ensures that only one scope of keys is loaded at a time, increasing performance on the page.

This also simplifies in-component logic in a few spots, moving that to the graphql client.

Changelog: added

Screenshots or screen recordings

Screen_Recording_2023-12-12_at_11.47.36_AM

Note the per page variable has been tweaked to show pagination, I don't want to create 20 ssh keys.

How to set up and validate locally

  1. Navigate to a project's Settings > Repository
  2. Expand the Deploy Keys section
  3. generate an ssh key (provide a file name so it's easier to find)
  4. add the generated ssh key to the project
  5. see the key!

NOTE: For pagination to show up, you need to add at least 6 keys

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

For #407604 (closed)

Edited by Andrew Fontaine

Merge request reports