Skip to content

Add new attribute to check codequality report status

Ahmed Hemdan requested to merge quick-fix-for-codequality-endpoint-status into master

What does this MR do and why?

This merge request add a new attribute to diffs_tab_pane_data merge request helper method to return the status of the compared codequality report generated for the head pipeline of a merge request (via merge_request.has_code_quality_reports?) similar to what we do with sast_report_available attribute in the same method.

This is to remedy the issue of frontend using endpoint_codequality attribute in the same helper method to determine the status of the codequality report displayed in a merge request inline findings, which points to a different method (i.e. merge_request.has_codequality_mr_diff_report?) that is no longer used for displaying code quality degradations as inline findings in a merge request changes tab (see &10959 for further information on this).

A follow-up to this from frontend will be submitted after this is merged to ensure it points to the correct report status moving on.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ahmed Hemdan

Merge request reports