Users can see a Zoekt error
requested to merge 432589-users-can-see-a-zoekt-error-in-the-ui-even-when-zoekt-search-isn-t-enabled into master
What does this MR do and why?
Fixed the search indicator.
Users can see a Zoekt error in the UI even when Zoekt search isn't enabled
This is the correct matrix of behaviour:
| search level | advanced | zoekt |
|---|---|---|
| global | shows advanced enabled | shows advanced enabled |
| group | shows advanced enabled | shows zoekt enabled ignores repository_ref* |
| project | shows advanced enabled/disabled respects repository_ref | shows zoekt enabled/disabled respects repository_ref* |
*this assumes that you have zoekt enabled on namespace that you are inspecting
Screenshots or screen recordings
advanced
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
 |
 |
zoekt
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
 |
 |
How to set up and validate locally
- Visit advanced search page e.g.
http://gdk.test:3000/search?scope=blobs&search=test&repository_ref=alunny%2Fpublish_lib&group_id=33&project_id=7 - Things to validate is combination of global, group, project in advanced search vs zoekt search
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #432589 (closed)
Edited by Tomas Bulva