Skip to content

Add redis-namespace gem for mailroom

Sylvester Chin requested to merge sc1-add-redis-namespace-gem into master

What does this MR do and why?

This MR adds redis-namespace gem back to the Gitlab application's Gemfile. This reverts the change in !135344 (comment 1677621172) and also updates the gem to 1.10. The gitlab mailroom gem needs redis-namespace as it is defined as a development dependency (https://gitlab.com/gitlab-org/ruby/gems/gitlab-mail_room/-/blob/578c314fc5d936978fafdea68952f9a5b2f7fe7d/mail_room.gemspec#L36).

See the issue #433493 (comment 1679836628).

Mailroom uses redis-namespace as a development dependency. In gitlab-org/charts/gitlab!3419 (diffs), it "deprecates" the use of namespace by not configuring the mailroom to use namespace for the Sidekiq delivery method. But the mailroom gem still could use namespace for Sidekiq delivery if the configuration is overrode. Furthermore since arbitration could use namespace, redis-namespace is still a dependency for mailroom.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sylvester Chin

Merge request reports