Dont remove instrumentation key unnecessarily
What does this MR do and why?
Product analytics can be configured project level, meaning users can provide a product_analytics_configurator_connection_string different than their instance level product_analytics_instrumentation_key which is configured in admin settings.
When a project level product_analytics_configurator_connection_string is provided, we need to clear product_analytics_instrumentation_key as the previous one will become invalid. InitializeSnowplowProductAnalyticsWorker will set a new product_analytics_instrumentation_key after calling the new analytics configurator located at product_analytics_configurator_connection_string.
However, we should not clean up product_analytics_configurator_connection_string when users didn't provide a product_analytics_configurator_connection_string. Otherwise it causes their dashboards to not show up and go back to onboarding state.
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Set up product analytics. For more information on setting up product analytics locally, see this video walkthrough.
- Visit a project settings page -> Analytics -> Save the form without changing
Snowplow configurator connection string - Go to Analyze -> Analytics dashboards in the sidebar
- Your dashboards should still be visible
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #434074 (closed)