Skip to content

Unset QA_TESTS in gdk-qa-parallel rule

Harsha Muralidhar requested to merge hm-unset-qa-tests-only-in-reliable-job into master

What does this MR do and why?

As an unintended consequence of !137821 (merged), I observed that in MRs where QA_TESTS is set, instead of just executing gdk-qa-reliable-selective it is also executing gdk-qa-reliable parallel jobs.

Example pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1098280324 where this happened.

This MR tries to address it by unsetting QA_TESTS just in gdk-qa-reliable job definition instead of .parallel job definition so that .rules:gdk:qa-parallel: is considered. If it is unset in .parallel template definition, gdk-qa-reliable jobs are still triggered because the rule didn't work correctly.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Harsha Muralidhar

Merge request reports