Skip to content
Snippets Groups Projects

Refactor SamlMembershipRoleSelector component

What does this MR do and why?

Extract a shareable RoleSelector component from the SamlMembershipRoleSelector component so it can be reused for other role selectors in the future.

In addition, use the existing logic for populating member dropdowns.

Issue: #417201 (closed)

How to set up and validate locally

  1. Enable Group SAML
    gdk config set omniauth.group_saml.enabled true && gdk reconfigure && gdk restart rails-web
  2. Create a group with Ultimate license
  3. Go to http://localhost:3000/groups/${group_id}/-/settings/roles_and_permissions and create a custom role with Developer base access
  4. Go to http://localhost:3000/groups/${group_id}/-/settings/roles_and_permissions and create a custom role
  5. Go to http://localhost:3000/groups/${group_id}/-/saml, fill in the required form fields and select the custom role

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Buijs

Merge request reports

Merged results pipeline #1103708787 passed

Pipeline: GitLab

#1103738460

    Pipeline: E2E GDK

    #1103727846

      Pipeline: TRIGGERED_EE_PIPELINE

      #1103738512

        +2

        Merged results pipeline passed for b66696a3

        Test coverage 82.54% (13.34%) from 2 jobs

        Merged by Kerri MillerKerri Miller 1 year ago (Dec 12, 2023 12:37pm UTC)

        Loading

        Pipeline #1104020929 passed

        Pipeline passed for 1f5d172e on master

        Test coverage 66.87% (13.34%) from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        Please register or sign in to reply
        Loading