Fix pipeline#stage frontend caching
What does this MR do and why?
This MR fixes pipeline#stage
frontend caching, which is behind a default disabled FF (pipeline_stage_set_last_modified
). As part of !138499 (merged) we've added a expires_in
call in addition to the stale?
call, which caused this bug.
It turned out that stale?
and expires_in
don't work well together. In this case, expires_in
overwrites Cache-Control
from max-age=0, private, must-revalidate
to max-age=86400, private
, which indicates to the browser that it can completely skip the request, which wasn't our intention. We always need to send the request to check if Last-Modified
and Etag
were modified.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.