Skip to content

Remove show_super_sidebar? usage from a few places

Lukas 'ai-pi' Eipert requested to merge leipert-remove-show-supersidebar-helper-calls into master

What does this MR do and why?

Remove show_super_sidebar? usage from page_class

show_super_sidebar? is now always true, so we can simplify the page_class helper.

Remove show_super_sidebar? from a few templates

It's always true, so these usages can be simplified!

Stop exposing the show_super_sidebar? on gon

All usages of gon.use_new_navigation have been removed from Vue / JavaScript files. So there is no need to expose this on the gon object any longer.

Screenshots or screen recordings

Before After
Screenshot_2023-12-06_at_14.20.59 Screenshot_2023-12-06_at_14.20.34

How to set up and validate locally

  1. The super sidebar should still be rendered
  2. The styles on the search results page should still be the same

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports